Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

emilio
style: Fix Gecko build after #20506.
simartin
Issue #20623: Check the input to WebGLRenderingContext's clear().
upsuper
style: Rename from_url_value_data to from_url_value and reuse URLValue passed in for ComputedUrl.

Bug: 1461858
Reviewed-by: emilio
MozReview-Commit-ID: LJGm3lUS9mD
upsuper
style: Make creating CssUrl infallible.

There were a check in CssUrl::parse_from_string for extra data, which
was removed as part of servo/servo#16241, so it never fails now.

CssUrl::from_url_value_data doesn't seem to need Result from the very
beginning. It is unclear why it was made that way.

Bug: 1461858
Reviewed-by: emilio
MozReview-Commit-ID: LXzKlZ6wPYW
bors-servo
Auto merge of #20780 - gterzian:fix_beforeunload_test, r=cbrewster

update "navigation within beforeunload" test to match the spec

<!-- Please describe your changes on the following line: -->
Follow up on https://github.com/servo/servo/pull/20329#issuecomment-387138449
@cbrewster

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20780)
<!-- Reviewable:end -->
emilio
style: Fix font-stretch animation.

This is a regression from #20506 which Gecko tests caught while trying to import
this.
bors-servo
Auto merge of #20838 - emilio:gecko-sync, r=emilio

style: Sync changes from mozilla-central.

See each individual commit for details.
gterzian
move msg to embedder_traits, use in script, handle send error in embedder
gterzian
update "navigation within beforeunload" test to match the spec
bors-servo
Auto merge of #20707 - gterzian:embedder_handling_of_prompts_and_alerts_2, r=paulrouget

Embedder handling of prompts and alerts

<!-- Please describe your changes on the following line: -->

Allow embedder to allow alerts and prompts, but via constellation forwarding messages from script.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #19992  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20707)
<!-- Reviewable:end -->
gterzian
move top_level_browsing_context_id out of embedder msg
upsuper
style: Have from_image_request reuse ImageValue from image request directly.

And also remove ComputedImageUrl::from_url_value_data.

Bug: 1461858
Reviewed-by: emilio
MozReview-Commit-ID: 5zifQlU7tOz
upsuper
style: Use RefPtr::new instead of RefPtr::from_ptr_ref + clone.

Bug: 1461858
Reviewed-by: emilio
upsuper
style: Make from_image_request infallible.

All callsites already assert, so moving the assertion into the method
should be fine. It is not expected to handle a null image value anyway.

Bug: 1461858
Reviewed-by: emilio
MozReview-Commit-ID: J8CA8m22eSv
MatsPalmgren
style: Inlinify display:list-item to display:inline for now, until we support 'display:inline list-item' properly.

Bug: 1461039
Reviewed-by: xidorn
bors-servo
Auto merge of #20843 - emilio:font-stretch-anim, r=emilio

style: Fix font-stretch animation.

This is a regression from #20506 which Gecko tests caught while trying to import
this.
gterzian
send message to embedder in prompt_to_unload
bors-servo
Auto merge of #20669 - simartin:issue_20623, r=jdm

Issue #20623: Check the input to WebGLRenderingContext's clear().

Validate the input to this function as per specifications.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20623
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20669)
<!-- Reviewable:end -->