Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

julientregoat
fix fn name issue
bors-servo
Auto merge of #25504 - Manishearth:features, r=asajeffrey

Support features in webxr

Based on https://github.com/servo/webxr/pull/119

Todo:
- [x] gate reference space creation on feature presence
- [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
bors-servo
Auto merge of #25573 - servo-wpt-sync:wpt_update_22-01-2020, r=servo-wpt-sync

Sync WPT with upstream (22-01-2020)

Automated downstream sync of changes from upstream as of 22-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
Manishearth
Update webxr
servo-wpt-sync
Update web-platform-tests to revision cbbb68edacd8d7dfb23b74f50537b72e06870511
Manishearth
Support profiles
Manishearth
Update xrSession_features_deviceSupport to use new user activations for each session request
julientregoat
Refactor ImageCache::find_image_or_metadata API.
Manishearth
Add support for requesting features
jdm
Remove intermittent failure.
pshaughn
Names should now be consistently atoms
Manishearth
Handle SetTargetRayMode and SetHandedness
Manishearth
Gate reference space creation on requested features
bors-servo
Auto merge of #25504 - Manishearth:features, r=asajeffrey

Support features in webxr

Based on https://github.com/servo/webxr/pull/119

Todo:
- [x] gate reference space creation on feature presence
- [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
Manishearth
Update xrSession_features_deviceSupport to use new user activations for each session request
Manishearth
Gate reference space creation on requested features
pshaughn
Names should now be consistently atoms
Manishearth
Correctly unset pending flag
bors-servo
Auto merge of #25572 - pshaughn:atomnames, r=<try>

Make name content attributes consistently atoms and put them in rare_data for fast access

<!-- Please describe your changes on the following line: -->
All codepaths setting the name content attribute now use an atom, which is also stored in rare_data for direct lookup by a get_name method.

Paralleling the get_name method, I added a get_id method, which makes some internal id-lookup cases nicer.

A new test tests for a name setter on every HTML element type. In addition to its overt and upstreamable purpose of checking IDL property reflection semantics, for us this test also hits some Servo assertions that make sure the name is an atom in every case. If the test doesn't crash, even a failed test case still has the attribute as an atom rather than some other type. The failed cases are for elements that we have unimplemented or completely stubbed; I added a few missing name IDL properties to otherwise implemented elements.

I also made a _mozilla copy of the working part of an existing but not-working test, as I explain in https://github.com/servo/servo/issues/25057#issuecomment-576865510

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25570 and make progress on #25057

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
Auto merge of #25573 - servo-wpt-sync:wpt_update_22-01-2020, r=jdm

Sync WPT with upstream (22-01-2020)

Automated downstream sync of changes from upstream as of 22-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
bors-servo
Auto merge of #25573 - servo-wpt-sync:wpt_update_22-01-2020, r=jdm

Sync WPT with upstream (22-01-2020)

Automated downstream sync of changes from upstream as of 22-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
bors-servo
Auto merge of #23661 - julientregoat:i-21289, r=<try>

Refactor ImageCache::find_image_or_metadata -> ImageCache::{get_image, track_image}

<!-- Please describe your changes on the following line: -->
Updated the `ImageCache` trait to replace `find_image_or_metadata` with two new functions `track_image` and `get_image`, as well as a new enum (`ImageCacheResult`).

As a result, I was able to refactor the functions that previously called `find_image_or_metadata` pretty cleanly. For a list of these functions, please see the commit information.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21289  (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because tests already exist for these components. I ran `cargo test` in `net`, `net_traits`, `layout`, and `script` successfully.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23661)
<!-- Reviewable:end -->
bors-servo
Auto merge of #25573 - servo-wpt-sync:wpt_update_22-01-2020, r=jdm

Sync WPT with upstream (22-01-2020)

Automated downstream sync of changes from upstream as of 22-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
bors-servo
Auto merge of #25572 - pshaughn:atomnames, r=<try>

Make name content attributes consistently atoms and put them in rare_data for fast access

<!-- Please describe your changes on the following line: -->
All codepaths setting the name content attribute now use an atom, which is also stored in rare_data for direct lookup by a get_name method.

Paralleling the get_name method, I added a get_id method, which makes some internal id-lookup cases nicer.

A new test tests for a name setter on every HTML element type. In addition to its overt and upstreamable purpose of checking IDL property reflection semantics, for us this test also hits some Servo assertions that make sure the name is an atom in every case. If the test doesn't crash, even a failed test case still has the attribute as an atom rather than some other type. The failed cases are for elements that we have unimplemented or completely stubbed; I added a few missing name IDL properties to otherwise implemented elements.

I also made a _mozilla copy of the working part of an existing but not-working test, as I explain in https://github.com/servo/servo/issues/25057#issuecomment-576865510

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25570 and make progress on #25057

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->