Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

mbrubeck
Make layout depend on style/servo feature

This fixes an error when running commands like `./mach check -p layout`.
bors-servo
Auto merge of #19580 - birtles:update-web-animations-link, r=hiro

Update references to Web Animations spec

This has been reviewed in [Gecko bug 1425548](https://bugzilla.mozilla.org/show_bug.cgi?id=1425548).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19580)
<!-- Reviewable:end -->
  • doc: 'etc/ci/upload_docs.sh' failed -  stdio
fenak
style: move list-style-image out of mako

cleaner way to set boxed param

redefine get_initial_value to none

make parse method clearer

remove some extra lines
bors-servo
Auto merge of #19578 - emilio:parse-keyword, r=Manishearth,canaltinova

Allow deriving Parse on keywords.

This makes patches like #19576 much easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19578)
<!-- Reviewable:end -->
asajeffrey
Downgrade to rustc nightly-2017-11-14.
bors-servo
Auto merge of #19568 - pyfisch:background-origin-gradients1, r=mbrubeck

layout: background-origin attribute for gradients

Fixes the glitches mentioned in #19554.
Now gradient tiles are placed in the whole bounding box.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19568)
<!-- Reviewable:end -->
bors-servo
Auto merge of #19570 - fenak:list-style-image-mako, r=emilio

style: move list-style-image out of mako

<!-- Please describe your changes on the following line: -->
Moving `list-style-image` out of mako.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19557  (part of #19015 ).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19570)
<!-- Reviewable:end -->
bors-servo
Auto merge of #19569 - asajeffrey:script-perf-measure-topLevelDomComplete, r=jdm

Add a topLevelDomComplete metric.

<!-- Please describe your changes on the following line: -->

Measure DOM completion without iframes. This is in support of measuring when the main document is loaded, ignoring secondary content, e.g. ads.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19561
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19569)
<!-- Reviewable:end -->
  • doc: 'etc/ci/upload_docs.sh' failed -  stdio
mbrubeck
Turn flow::base and friends into methods
bors-servo
Auto merge of #19562 - mbrubeck:feature, r=emilio

Make layout depend on style/servo feature

This fixes an error when running commands like `./mach check -p layout`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they change build metadata only

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19562)
<!-- Reviewable:end -->
pyfisch
layout: background-origin attribute for gradients

Fixes the glitches mentioned in #19554.
Now gradient tiles are placed in the whole bounding box.
emilio
style: Slightly simplify push_applicable_declarations.
bors-servo
Auto merge of #19564 - emilio:push-applicable-simple, r=mbrubeck

style: Slightly simplify push_applicable_declarations.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19564)
<!-- Reviewable:end -->
  • linux-rel-nogate: 'env CC=gcc-5 ...' failed -  stdio
emilio
style: Use derive(Parse) for X and Y.
bors-servo
Auto merge of #17580 - edunham:taskcluster, r=aneeshusa

Add rudimentary .taskcluster.yml

Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the
linux-dev builder in etc/ci/buildbot_steps.yml, but with the real parts
commented out for speed during the testing process.

r? @aneeshusa

I got the first-draft image built and pushed to docker hub at https://hub.docker.com/r/servobrowser/servo-linux-dev which is what this is set to pull from.

cc @gregarndt @imbstack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17580)
<!-- Reviewable:end -->
emilio
Allow deriving Parse for keywords.
bors-servo
Auto merge of #19554 - pyfisch:tiled-gradients1, r=mbrubeck

layout: support tiled gradients

Use background-size, background-position properties to render
CSS gradients.

Some cleanup in display_list_builder.rs related to gradient
calculations.

Adds two wpt tests for tiled gradients.

Note: For now even gradients with background-repeat: no-repeat
are repeated. Sometimes the gradient is not repeated everywhere.

Resolves partially #19482. (See the mentioned website for example gradients with these features)
See also: #16657 and #10412

Some glitches can be seen in the attached file. I am unsure what the exact intended semantics of [`push_gradient`](https://doc.servo.org/webrender_api/struct.DisplayListBuilder.html#method.push_gradient) are and want to ask the webrender team before building in "workarounds" for the missing gradients.
![half-rhombes](https://user-images.githubusercontent.com/2781017/33958051-b16f964a-e043-11e7-8218-b28388e2cf8d.png)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19554)
<!-- Reviewable:end -->
  • doc: 'etc/ci/upload_docs.sh' failed -  stdio
edunham
Add .taskcluster.yml

Template mostly from https://tools.taskcluster.net/quickstart/. Steps from the
linux-dev builder in etc/ci/buildbot_steps.yml are in taskcluster-test.sh.
emilio
style: Handle servo-prefixed stuff correctly.
bors-servo
Auto merge of #19565 - mbrubeck:base, r=emilio

Turn flow::base and friends into methods

This feels more idiomatic in modern Rust, and replaces code like this:

`flow::base(&**root_flow).restyle_damage`

with this:

`root_flow.base().restyle_damage`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are refactoring only

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19565)
<!-- Reviewable:end -->
emilio
style: Use derive(Parse) for RepeatKeyword.
neerjapancholi
Update bindings.
bors-servo
Auto merge of #19579 - neerjapancholi:master, r=emilio

Bug 1417725 - (Servo) Add -moz-column-span alias for column-span prop…

…erty.

<!-- Please describe your changes on the following line: -->
This is part of the patch for adding a -moz- alias for column-span. See https://bugzilla.mozilla.org/show_bug.cgi?id=1417725
Clean try run for this patch is at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=faa9c050c9adf10714953b8c5d5af67683992437&selectedJob=151353901

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19579)
<!-- Reviewable:end -->
  • linux-dev: ran build-geckolib failed -  stdio
  • linux-rel-css: ran build-geckolib --release failed -  stdio
  • mac-rel-css1: ran build --release failed -  stdiowarnings (1)
  • mac-rel-wpt2: ran build-geckolib --release failed -  stdio
  • windows-msvc-dev: ran build-geckolib failed -  stdio
bors-servo
Auto merge of #19558 - emilio:sadness, r=heycam

selectors: Manually inline any(..) in matches_selector_list.

Since the compiler refuses to inline the inner closure even with -O3, which is
sad :(.

Sad try run:

  https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=c2724c47e98f990826327da05220cd83b772d144&newProject=try&newRevision=52ac88b40a08a5ef6a629bd681f2e5a444b75f54&framework=1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19558)
<!-- Reviewable:end -->
asajeffrey
Add a smoketest to the mac-rel-wpt1 builder.
neerjapancholi
Bug 1417725 - (Servo) Add -moz-column-span alias for column-span property.
bors-servo
Auto merge of #19574 - asajeffrey:rustdown-2017-11-14, r=<try>

Downgrade to rustc nightly-2017-11-14

<!-- Please describe your changes on the following line: -->

This is causing nightly servo to crash with hardware acceleration.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19519
- [X] These changes do not require tests because testing requires AWS instances with GPUs.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574)
<!-- Reviewable:end -->
birtles
Update references to Web Animations spec
asajeffrey
Add a topLevelDomComplete metric.