Builder linux-rel-wpt Build #8807

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 2 secs )
   1. stdio
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. shell__1 './mach clean-nightlies ...' ( 10 secs )
   1. stdio
6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
   1. stdio
7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
   1. stdio
8. compile ran build --release --with-debug-assertions warnings ( 3 mins, 58 secs )
   1. warnings (1)
9. test ran test-wpt-failure ( 0 secs )
   1. stdio
10. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 14 mins, 58 secs )
    1. - no logs -
11. shell__4 './mach filter-intermittents ...' ( 1 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
12. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 9 secs )
    1. wpt-mp-errorsummary.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #81233

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Wed 23 May 2018 19:59:32
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	auto
   Revision	0cad37718da6d1665cc3e89e0924ad430952e566

   Comments

   Auto merge of #20840 - fabricedesre:save-localstorage, r=Manishearth
   
   Save local storage at every change and not just on shutdown
   
   <!-- Please describe your changes on the following line: -->
   Currently local storage is saved to `local_data.json` only at shutdown when the storage thread receives the `StorageThreadMsg::Exit` message. This is not reliable enough in any case, and especially problematic for a young engine like Servo. Data loss ensues...
   
   I kept the exit message in the storage thread even if we are not doing work anymore. I can remove it if needed but it should be useful once we move to a better storage backend than a json file.
   
   ---
   <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
   - [x] `./mach build -d` does not report any errors
   - [x] `./mach test-tidy` does not report any errors
   - [ ] These changes fix #__ (github issue number if applicable).
   
   <!-- Either: -->
   - [ ] There are tests for these changes OR
   - [x] These changes do not require tests because we don't have tests for that persistence layer.
   
   <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
   
   <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20840)
   <!-- Reviewable:end -->

   Changed files

   • components/net/storage_thread.rs