Builder linux-rel-wpt Build #8572

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 3 secs )
   1. stdio
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. shell__1 './mach clean-nightlies ...' ( 11 secs )
   1. stdio
6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
   1. stdio
7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
   1. stdio
8. compile ran build --release --with-debug-assertions ( 11 mins, 7 secs )
   1. - no logs -
9. test ran test-wpt-failure ( 0 secs )
   1. stdio
10. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 16 mins, 42 secs )
    1. - no logs -
11. shell__4 './mach filter-intermittents ...' ( 14 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
12. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 9 secs )
    1. wpt-mp-errorsummary.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #79432

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Mon 23 Apr 2018 21:13:49
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	try
   Revision	e24827d2de503213e29dbf526a137d814caf5220

   Comments

   Auto merge of #20680 - Brody-Eastwood:master, r=<try>
   
   Moved Canvas rendering to a single thread.
   
   <!-- Please describe your changes on the following line: -->
   
   Implements the "Subsequent Steps" part of the [NCSU Canvas rendering project.](https://github.com/servo/servo/wiki/Canvas-rendering-project)
   
   I moved most of the functionality from CanvasPaintThread to CanvasData, so CanvasPaintThread essentially just pulls the info out of the message and calls a method on a particular CanvasData element.
   
   I ran into some awkwardness with the fact that one can only take a single mutable reference from a hashmap, though. DrawImageInOther is not really possible to do with only one reference at a time, so it awkwardly still lives in CanvasPaintThread, basically. I also would've preferred to take the reference at the top as soon as I get the CanvasId, since that looks cleaner than having them all start with "canvas_paint_thread.canvases.get_mut[&canvas_id].unwrap()" but that makes trying to take the second reference for DrawImageInOther fail to compile. I'm definitely open to suggestions on how to make that less gross.
   
   The timed single-canvas drawing improved in performance from around ~2.2ms to around ~1.7ms. Slither.io runs better and doesn't crash, but I'm not having it crash on my copy from before these changes, so I don't know if that's new behavior or not.
   
   ---
   <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
   - [X] `./mach build -d` does not report any errors
   - [X] `./mach build-geckolib` does not report any errors
   - [X] `./mach test-tidy` does not report any errors
   - [X] These changes fix #13879 and #10381.
   
   <!-- Either: -->
   - [X] There are tests for these changes (added in the initial steps)
   
   <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
   
   <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20680)
   <!-- Reviewable:end -->

   Changed files

   • components/canvas/canvas_data.rs
   • components/canvas/canvas_paint_thread.rs
   • components/canvas/lib.rs
   • components/canvas_traits/canvas.rs
   • components/constellation/constellation.rs
   • components/script/dom/canvasrenderingcontext2d.rs