Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-wpt Build #7365

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchauto
Revisionbcdb82b83fcf652a29ba49cf1fe032299d26e52c
Got Revisionbcdb82b83fcf652a29ba49cf1fe032299d26e52c
Changes1 change

BuildSlave:

servo-linux1

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 9 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 9 secs )
    1. stdio
  6. compile ran build --release --with-debug-assertions ( 23 mins, 22 secs )
    1. - no logs -
  7. test ran test-wpt-failure ( 0 secs )
    1. stdio
  8. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 22 mins, 14 secs )
    1. wpt-errorsummary.log
  9. shell__2 './mach filter-intermittents ...' ( 1 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
    3. intermittents.log
  10. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 9 secs )
    1. stdio
    2. wpt-mp-errorsummary.log

Build Properties:

NameValueSource
branch auto Build
builddir /home/servo/buildbot/slave/linux-rel-wpt slave
buildername linux-rel-wpt Builder
buildnumber 7365 Build
codebase Build
got_revision bcdb82b83fcf652a29ba49cf1fe032299d26e52c Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision bcdb82b83fcf652a29ba49cf1fe032299d26e52c Build
scheduler servo-auto Scheduler
slavename servo-linux1 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-wpt slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartFri Dec 22 21:37:00 2017
EndFri Dec 22 22:23:07 2017
Elapsed46 mins, 6 secs

All Changes:

:

  1. Change #70731

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Fri 22 Dec 2017 21:36:59
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch auto
    Revision bcdb82b83fcf652a29ba49cf1fe032299d26e52c

    Comments

    Auto merge of #19630 - yati-sagade:master, r=jdm
    
    Paint worklets: Add pref for blocking sleep to be enabled for wpt tests
    
    In aa48a2c2e3c7699a167d9ffe791f4bb17e9b9f1c I added a timeout for paint
    worklet threads. However, the test was broken. The blocking sleep
    function that was implemented as part of that commit was guarded behind
    the `dom.worklet.blockingsleep.enabled` pref, and while I ran the
    wpt-tests with that pref enabled, the test runner for sure did not.
    I tried running the test _without_ the pref enabled, and the tests still
    pass. This is because even the reference in that reftest is that of
    a broken image background, and *both* the paintworklet thread timing out
    and `sleep()` not being in scope would render the same thing: a broken
    image, which compares equal to the reference.
    
    This patch makes sure that now the pref is enabled for wpt worklet
    tests, and that such we can distinguish an actual timeout (test pass)
    from an unexpected situation (when we should fail the test).
    
    <!-- Please describe your changes on the following line: -->
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
    - [X] `./mach build -d` does not report any errors
    - [X] `./mach test-tidy` does not report any errors
    - [X] These changes fix #__ (github issue number if applicable). (*not applicable*)
    
    <!-- Either: -->
    - [] There are tests for these changes OR
    - [X] These changes do not require tests because this patch fixes a broken test.
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19630)
    <!-- Reviewable:end -->

    Changed files

    • tests/wpt/mozilla/meta/MANIFEST.json
    • tests/wpt/mozilla/meta/mozilla/worklets/__dir__.ini
    • tests/wpt/mozilla/tests/mozilla/worklets/test_paint_worklet_timeout.js