Builder linux-rel-wpt Build #7207

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 4 secs )
   1. stdio
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. shell__1 './mach clean-nightlies ...' ( 10 secs )
   1. stdio
6. compile ran build --release --with-debug-assertions ( 21 mins, 3 secs )
   1. - no logs -
7. test ran test-wpt-failure ( 0 secs )
   1. stdio
8. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 17 mins, 29 secs )
   1. wpt-errorsummary.log
9. shell__2 './mach filter-intermittents ...' ( 0 secs )
   1. stdio
   2. filtered-wpt-errorsummary.log
   3. intermittents.log
10. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 8 secs )
    1. stdio
    2. wpt-mp-errorsummary.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #69941

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Wed 06 Dec 2017 20:29:37
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	auto
   Revision	6a6da9c2a4805d28365961c6ecd1e8dc7559b0b1

   Comments

   Auto merge of #19471 - jonleighton:input-type, r=jdm
   
   Expand InputType to cover all possible types
   
   This came out of a conversation with nox in IRC:
   https://mozilla.logbot.info/servo/20171201#c13946454-c13946594
   
   The code I was working on which motivated this change is here:
   https://github.com/servo/servo/pull/19461
   
   Previously, InputType::Text was used to represent several different
   values of the type attribute on an input element.
   
   If an input element doesn't have a type attribute, or its type attribute
   doesn't contain a recognised value, then the input's type defaults to
   "text".
   
   Before this change, there were a number of checks in the code which
   directly looked at the type attribute. If those checks matched against
   the value "text", then they were potentially buggy, since an input with
   type=invalid should also behave like an input with type=text.
   
   Rather than have every conditional which cares about the input type also
   have to deal with invalid input types, we can convert the type attribute
   to an InputType enum once, and then match against the enum.
   
   A secondary benefit is that the compiler can tell us whether we've
   missed branches in a match expression. While working on this I
   discovered that the HTMLInputElement::value_mode() method misses a case
   for inputs with type=hidden (this resulted in a failing WPT test
   passing).
   
   I've also implemented the Default trait for InputType, so we now only
   have one place in the code which knows that InputType::Text is the
   default, where previously there were several.
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19471)
   <!-- Reviewable:end -->

   Changed files

   • components/atoms/static_atoms.txt
   • components/script/dom/htmlelement.rs
   • components/script/dom/htmlformelement.rs
   • components/script/dom/htmlinputelement.rs
   • components/script/dom/radionodelist.rs
   • tests/wpt/metadata/html/semantics/forms/the-input-element/clone.html.ini