Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-wpt Build #12911

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchauto
Revision2dfbbd0ca24ae17cb282a0f02289b42e9334947b
Got Revision2dfbbd0ca24ae17cb282a0f02289b42e9334947b
Changes1 change

BuildSlave:

servo-linux4

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 2 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. stdio
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 14 secs )
    1. stdio
  6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
    1. stdio
  7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio
  8. compile ran build --release --with-debug-assertions -p servo ( 12 mins, 40 secs )
    1. - no logs -
  9. test ran test-wpt-failure ( 0 secs )
    1. stdio
  10. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 25 mins, 56 secs )
    1. - no logs -
  11. shell__4 './mach filter-intermittents ...' ( 1 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
  12. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 8 secs )
    1. wpt-mp-errorsummary.log
  13. test__3 ran test-wpt --release --product=servodriver --headless tests/wpt/mozilla/tests/mozilla/DOMParser.html tests/wpt/mozilla/tests/css/per_glyph_font_fallback_a.html tests/wpt/mozilla/tests/css/img_simple.html tests/wpt/mozilla/tests/mozilla/secure.https.html ( 9 secs )
    1. stdio
  14. test__4 ran test-wpt --release --product=servodriver --headless bluetooth ( 5 mins, 6 secs )
    1. bluetooth-errorsummary.log
  15. test__5 ran test-wpt --release --headless --timeout-multiplier=4 --always-succeed webdriver ( 3 mins, 31 secs )
    1. wdspec-errorsummary.log
  16. shell__5 './mach filter-intermittents ...' ( 0 secs )
    1. stdio
    2. filtered-wdspec-errorsummary.log
    3. intermittents.log
  17. shell__6 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch auto Build
builddir /home/servo/buildbot/slave/linux-rel-wpt slave
buildername linux-rel-wpt Builder
buildnumber 12911 Build
codebase Build
got_revision 2dfbbd0ca24ae17cb282a0f02289b42e9334947b Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 2dfbbd0ca24ae17cb282a0f02289b42e9334947b Build
scheduler servo-auto Scheduler
slavename servo-linux4 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-wpt slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartThu Jul 18 18:22:09 2019
EndThu Jul 18 19:10:02 2019
Elapsed47 mins, 52 secs

All Changes:

:

  1. Change #119694

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Thu 18 Jul 2019 18:22:09
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch auto
    Revision 2dfbbd0ca24ae17cb282a0f02289b42e9334947b

    Comments

    Auto merge of #23368 - gterzian:clean_up_navigation, r=asajeffrey
    
    Clean-up navigation
    
    <!-- Please describe your changes on the following line: -->
    
    1. Navigation as a result of following a hyperlink should be done in a task: https://html.spec.whatwg.org/multipage/links.html#following-hyperlinks:dom-manipulation-task-source
    2. The javascript url navigation should also be done in a task: https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigating-across-documents:dom-manipulation-task-source
    3. In `window.load_url`, it seems there is no need to send a message to the script-thread(the entirety of `load_url` should instead be done in a task when appropriate), so we can just do that last part "sync" by calling a method on the script, which will send a message to the constellation(for the parallel navigation steps), or queue task(for the JS navigation), as appropriate.
    4. Separate the "normal" navigation flow from the handling of "navigate an iframe" message from constellation, since doing everything in one method as was previously done with `handle_navigate`, is confusing.
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
    - [ ] `./mach build -d` does not report any errors
    - [ ] `./mach test-tidy` does not report any errors
    - [ ] These changes fix #___ (GitHub issue number if applicable)
    
    <!-- Either: -->
    - [ ] There are tests for these changes OR
    - [ ] These changes do not require tests because ___
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23368)
    <!-- Reviewable:end -->

    Changed files

    • components/constellation/constellation.rs
    • components/constellation/pipeline.rs
    • components/script/dom/htmlanchorelement.rs
    • components/script/dom/htmlformelement.rs
    • components/script/dom/htmliframeelement.rs
    • components/script/dom/location.rs
    • components/script/dom/window.rs
    • components/script/dom/windowproxy.rs
    • components/script/script_thread.rs
    • components/script_traits/lib.rs
    • components/script_traits/script_msg.rs
    • components/webdriver_server/lib.rs
    • tests/wpt/metadata/MANIFEST.json
    • tests/wpt/web-platform-tests/html/semantics/scripting-1/the-script-element/execution-timing/029.html