Builder linux-rel-wpt Build #12405

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 3 secs )
   1. stdio
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. shell__1 './mach clean-nightlies ...' ( 14 secs )
   1. stdio
6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
   1. stdio
7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
   1. stdio
8. compile ran build --release --with-debug-assertions -p servo ( 4 mins, 55 secs )
   1. - no logs -
9. test ran test-wpt-failure ( 0 secs )
   1. stdio
10. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 20 mins, 16 secs )
    1. wpt-errorsummary.log
11. shell__4 './mach filter-intermittents ...' ( 1 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
    3. intermittents.log
12. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 7 secs )
    1. wpt-mp-errorsummary.log
13. test__3 ran test-wpt --release --product=servodriver --headless tests/wpt/mozilla/tests/mozilla/DOMParser.html tests/wpt/mozilla/tests/css/per_glyph_font_fallback_a.html tests/wpt/mozilla/tests/css/img_simple.html tests/wpt/mozilla/tests/mozilla/secure.https.html ( 8 secs )
    1. stdio
14. test__4 ran test-wpt --release --processes 1 --product=servodriver --headless bluetooth ( 34 secs )
    1. bluetooth-errorsummary.log
15. shell__5 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #114670

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Thu 23 May 2019 16:01:32
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	auto
   Revision	f24f51796502abbefbbfda51212d28fe2b3db947

   Comments

   Auto merge of #23272 - tdelacour:ISSUE-20455, r=SimonSapin
   
   ISSUE-20455: introduce stronger types for textinput indexing
   
   <!-- Please describe your changes on the following line: -->
   Added two new types:
   - ByteOffset
   - UTF16CodeUnitOffset
   
   I've replaced any instance of `usize` that would be better represented by one or the other of these. I also updated any downstream code, including the unit tests for `textinput.rs`. Along the way, I tried to add or edit comments to better reflect my understanding of this file - happy to revisit if I have misrepresented anything.
   
   I did not end up finding any places where types were very obviously being mixed, as the issue description suggested I should do... LMK if I should re-audit the file for that (might need a bit of guidance)!
   
   ---
   <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
   - [X] `./mach build -d` does not report any errors
   - [X] `./mach test-tidy` does not report any errors
   - [X] These changes fix #20455 (GitHub issue number if applicable)
   
   <!-- Either: -->
   - [X] There are tests for these changes OR
   - [ ] These changes do not require tests because ___
   
   <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
   
   <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23272)
   <!-- Reviewable:end -->

   Changed files

   • components/script/dom/htmlinputelement.rs
   • components/script/dom/htmltextareaelement.rs
   • components/script/dom/textcontrol.rs
   • components/script/textinput.rs
   • tests/unit/script/textinput.rs