Builder linux-rel-wpt Build #10826

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 8 secs )
   1. stdio
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. shell__1 './mach clean-nightlies ...' ( 12 secs )
   1. stdio
6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
   1. stdio
7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
   1. stdio
8. compile ran build --release --with-debug-assertions -p servo warnings ( 10 mins, 5 secs )
   1. warnings (1)
9. test ran test-wpt-failure ( 0 secs )
   1. stdio
10. test__1 ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --always-succeed ( 19 mins, 21 secs )
    1. - no logs -
11. shell__4 './mach filter-intermittents ...' ( 1 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
12. test__2 ran test-wpt --release --binary-arg=--multiprocess --processes 24 eventsource ( 22 secs )
    1. wpt-mp-errorsummary.log
13. shell__5 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #102590

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Fri 16 Nov 2018 14:56:05
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	auto
   Revision	a2937d948818665ecda16a06fe6c8fa751d265fd

   Comments

   Auto merge of #21804 - AgustinCB:unify-task-source-canceller-api, r=gterzian
   
   Unify the task source and task canceller API
   
   To do so, I created a struct `TaskManagement(TaskSource,
   TaskCanceller)` and made `*_task_source` return that instead of just
   the task source.
   
   Next, I refactored all places in which `task_canceller` by basically
   removing them in favour of a previously called `*_task_source`.
   
   I tried to make `task_canceller` a private method in `Window`, with the
   hope of enforcing the use of `*_task_source`. However, it's used in
   components/script/dom/globalscope.rs:575 in such a way that will make it
   harder to avoid. I decided to leave it that way.
   
   It'd be possible to unify `*_task_source` in such a way that we would
   have only one method. However, I decided not to do it because one of the
   `TaskSource` implementations is special:
   `history_traversal_task_source`. Not wanting to over complicate things,
   I decided to leave the structure this way.
   
   ---
   - [x] `./mach build -d` does not report any errors
   - [x] `./mach test-tidy` does not report any errors
   - [x] These changes fix #21154 (github issue number if applicable).
   
   - [x] These changes do not require tests because it's refactoring code that should already be tested.
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21804)
   <!-- Reviewable:end -->

   Changed files

   • components/profile/time.rs
   • components/profile_traits/time.rs
   • components/script/dom/analysernode.rs
   • components/script/dom/audiocontext.rs
   • components/script/dom/audioscheduledsourcenode.rs
   • components/script/dom/baseaudiocontext.rs
   • components/script/dom/document.rs
   • components/script/dom/globalscope.rs
   • components/script/dom/htmldetailselement.rs
   • components/script/dom/htmldialogelement.rs
   • components/script/dom/htmlformelement.rs
   • components/script/dom/htmliframeelement.rs
   • components/script/dom/htmlimageelement.rs
   • components/script/dom/htmlinputelement.rs
   • components/script/dom/htmlmediaelement.rs
   • components/script/dom/htmlscriptelement.rs
   • components/script/dom/htmlstyleelement.rs
   • components/script/dom/htmltextareaelement.rs
   • components/script/dom/offlineaudiocontext.rs
   • components/script/dom/storage.rs
   • components/script/dom/textcontrol.rs
   • components/script/dom/window.rs
   • components/script/layout_image.rs
   • components/script/lib.rs
   • components/script/script_runtime.rs
   • components/script/script_thread.rs
   • components/script/stylesheet_loader.rs
   • components/script/task_manager.rs
   • components/script/task_source/history_traversal.rs