Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #8323

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchauto
Revision23b2f42a368cdc68548310e79b31306f40f95553
Got Revision23b2f42a368cdc68548310e79b31306f40f95553
Changes1 change

BuildSlave:

servo-linux5

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 3 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 11 secs )
    1. stdio
  6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
    1. stdio
  7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio
  8. compile ran build --release --with-debug-assertions ( 11 mins, 8 secs )
    1. - no logs -
  9. test ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 2 --always-succeed ( 10 mins, 0 secs )
    1. - no logs -
  10. shell__4 './mach filter-intermittents ...' ( 3 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
    3. intermittents.log
  11. compile__1 ran build-geckolib --release ( 2 mins, 30 secs )
    1. - no logs -
  12. test__1 ran test-stylo --release ( 38 secs )
    1. - no logs -
  13. shell__5 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  14. shell__6 'bash ./etc/ci/manifest_changed.sh' ( 42 secs )
    1. stdio
  15. shell__7 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch auto Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 8323 Build
codebase Build
got_revision 23b2f42a368cdc68548310e79b31306f40f95553 Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 23b2f42a368cdc68548310e79b31306f40f95553 Build
scheduler servo-auto Scheduler
slavename servo-linux5 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartSat Mar 24 18:03:27 2018
EndSat Mar 24 18:28:48 2018
Elapsed25 mins, 20 secs

All Changes:

:

  1. Change #77797

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Sat 24 Mar 2018 18:03:27
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch auto
    Revision 23b2f42a368cdc68548310e79b31306f40f95553

    Comments

    Auto merge of #20406 - kwonoj:feat-fetch-body-arraybuffer, r=jdm
    
    feat(fetch): accept arraybuffer in consume_body
    
    <!-- Please describe your changes on the following line: -->
    Related to https://github.com/servo/servo/issues/20346.
    
    I realized I am not sufficiently knowledgeable about codebases and have high confidence this PR is not ready to be accepted. Raising it as PR early to possibly ask some suggestions around codebases.
    
    If this PR seems unrecoverable by code review, please feel freely close and unassign me from issue πŸ™
    
    This PR tries to implement #20346, updating `Body` idl and implements corresponding implementation in `body.rs` for `fetch`. Criteria for changes may includes
    
    - does `run_array_buffer_data_algorithm` implementation is legit for allocating arraybuffer? (probably not)
    - does `run_array_buffer_data_algorithm` implementation is acceptable for handling error, by naively returning `Error::JSFailed`?
    - there are some number of wpt test started to PASS with this PR. Is this legit side effect, or something incorrect by current implementation?
    - etcs, vice versa
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
    - [x] `./mach build -d` does not report any errors
    - [x] `./mach test-tidy` does not report any errors
    - [x] These changes fix #20346 (github issue number if applicable).
    
    <!-- Either: -->
    - [ ] There are tests for these changes OR
    - [ ] These changes do not require tests because _____
    - wpt test has changed in PR, need to be reviewed.
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20406)
    <!-- Reviewable:end -->

    Changed files

    • components/script/body.rs
    • components/script/dom/request.rs
    • components/script/dom/response.rs
    • components/script/dom/webidls/Body.webidl
    • tests/wpt/metadata/fetch/api/basic/text-utf8.html.ini
    • tests/wpt/metadata/fetch/api/request/request-consume-empty.html.ini
    • tests/wpt/metadata/fetch/api/request/request-consume.html.ini
    • tests/wpt/metadata/fetch/api/request/request-idl.html.ini
    • tests/wpt/metadata/fetch/api/request/request-structure.html.ini
    • tests/wpt/metadata/fetch/api/response/response-consume.html.ini
    • tests/wpt/metadata/fetch/api/response/response-idl.html.ini
    • tests/wpt/metadata/fetch/api/response/response-stream-disturbed-5.html.ini
    • tests/wpt/metadata/fetch/data-urls/base64.any.js.ini
    • tests/wpt/metadata/fetch/data-urls/processing.any.js.ini