Builder linux-rel-css Build #8000

Results:

Build successful

SourceStamp:

Project	servo/servo
Repository	https://github.com/servo/servo
Branch	auto
Revision	f48dce120dddd8e3d585cfc8bc221faa2726bf6b
Got Revision	f48dce120dddd8e3d585cfc8bc221faa2726bf6b
Changes	1 change

BuildSlave:

servo-linux6

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

git update ( 4 secs )
1. stdio
generic generic ( 0 secs )
1. - no logs -
generic_1 generic_1 ( 0 secs )
1. - no logs -
shell 'pkill -x ...' ( 0 secs )
1. stdio
shell__1 './mach clean-nightlies ...' ( 10 secs )
1. stdio
shell__2 './mach clean-cargo-cache ...' ( 0 secs )
1. stdio
shell__3 './mach clean' ( 0 secs )
1. stdio
compile ran build --release --with-debug-assertions ( 9 mins, 57 secs )
1. - no logs -
test ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 2 --always-succeed ( 14 mins, 40 secs )
1. - no logs -
shell__4 './mach filter-intermittents ...' ( 3 secs )
compile__1 ran build-geckolib --release ( 5 mins, 54 secs )
1. - no logs -
test__1 ran test-stylo --release ( 1 mins, 56 secs )
1. - no logs -
shell__5 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
1. stdio
shell__6 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
1. stdio

Build Properties:

Name	Value	Source
branch	auto	Build
builddir	/home/servo/buildbot/slave/linux-rel-css	slave
buildername	linux-rel-css	Builder
buildnumber	8000	Build
codebase		Build
got_revision	f48dce120dddd8e3d585cfc8bc221faa2726bf6b	Git
project	servo/servo	Build
repository	https://github.com/servo/servo	Build
revision	f48dce120dddd8e3d585cfc8bc221faa2726bf6b	Build
scheduler	servo-auto	Scheduler
slavename	servo-linux6	BuildSlave
warnings-count	0	WarningCountingShellCommand
workdir	/home/servo/buildbot/slave/linux-rel-css	slave (deprecated)

Forced Build Properties:

Name	Label	Value

Responsible Users:

bors-servo
lbergstrom+borsohnoyoudont@mozilla.com

Timing:

Start	Thu Feb 22 16:05:59 2018
End	Thu Feb 22 16:38:48 2018
Elapsed	32 mins, 48 secs

All Changes:

:

Change #75325

Category	None
Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
Changed at	Thu 22 Feb 2018 16:05:59
Repository	https://github.com/servo/servo
Project	servo/servo
Branch	auto
Revision	f48dce120dddd8e3d585cfc8bc221faa2726bf6b

Comments

Auto merge of #20021 - jonleighton:lazy-font-group, r=mbrubeck,glennw

 Lazy load fonts in a FontGroup

The first commit message explains this so I'll just copy it here:

---

This is a step towards fixing #17267. To fix that, we need to be able to
try various different fallback fonts in turn, which would become
unweildy with the prior eager-loading strategy.

Prior to this change, FontGroup loaded up all Font instances, including
the fallback font, before any of them were checked for the presence of
the glyphs we're trying to render.

So for the following CSS:

    font-family: Helvetica, Arial;

The FontGroup would contain a Font instance for Helvetica, and a Font
instance for Arial, and a Font instance for the fallback font.

It may be that Helvetica contains glyphs for every character in the
document, and therefore Arial and the fallback font are not needed at
all.

This change makes the strategy lazy, so that we'll only create a Font
for Arial if we cannot find a glyph within Helvetica. I've also
substantially refactored the existing code in the process and added
some documentation along the way.

---

I've added some tests in the second commit, but it required quite a bit of gymnastics to make it possible to write such a test. I'm not sure if the added complexity to the production code is worth it?

On the other hand, having this infrastructure in place may be useful for testing future changes in this area, and also possibly brings us a step closer to extracting a library as discussed in #4901. (What I mean by that is: it reduces coupling between `FontCacheThread` and `FontContext` -- the latter would have a place in such a library, the former wouldn't.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20021)
<!-- Reviewable:end -->

Changed files

components/gfx/font.rs
components/gfx/font_cache_thread.rs
components/gfx/font_context.rs
components/gfx/font_template.rs
components/gfx/platform/freetype/font.rs
components/gfx/platform/macos/font.rs
components/gfx/platform/windows/font.rs
components/gfx/tests/font_context.rs
components/gfx/tests/support/CSSTest/LICENSE
components/gfx/tests/support/CSSTest/README
components/gfx/tests/support/CSSTest/csstest-ascii.ttf
components/gfx/tests/support/CSSTest/csstest-basic-bold.ttf
components/gfx/tests/support/CSSTest/csstest-basic-bolditalic.ttf
components/gfx/tests/support/CSSTest/csstest-basic-italic.ttf
components/gfx/tests/support/CSSTest/csstest-basic-regular.ttf
components/gfx/tests/support/CSSTest/csstest-fallback.ttf
components/gfx/tests/support/CSSTest/csstest-familyname-bold.ttf
components/gfx/tests/support/CSSTest/csstest-familyname-funkyA.ttf
components/gfx/tests/support/CSSTest/csstest-familyname-funkyB.ttf
components/gfx/tests/support/CSSTest/csstest-familyname-funkyC.ttf
components/gfx/tests/support/CSSTest/csstest-familyname.ttf
components/gfx/tests/support/CSSTest/csstest-verify.ttf
components/gfx/tests/support/CSSTest/csstest-weights-100.ttf
components/gfx/tests/support/CSSTest/csstest-weights-1479-w1.ttf
components/gfx/tests/support/CSSTest/csstest-weights-1479-w4.ttf
components/gfx/tests/support/CSSTest/csstest-weights-1479-w7.ttf
components/gfx/tests/support/CSSTest/csstest-weights-1479-w9.ttf
components/gfx/tests/support/CSSTest/csstest-weights-15-w1.ttf
components/gfx/tests/support/CSSTest/csstest-weights-15-w5.ttf
components/gfx/tests/support/CSSTest/csstest-weights-200.ttf
components/gfx/tests/support/CSSTest/csstest-weights-24-w2.ttf
components/gfx/tests/support/CSSTest/csstest-weights-24-w4.ttf
components/gfx/tests/support/CSSTest/csstest-weights-2569-w2.ttf
components/gfx/tests/support/CSSTest/csstest-weights-2569-w5.ttf
components/gfx/tests/support/CSSTest/csstest-weights-2569-w6.ttf
components/gfx/tests/support/CSSTest/csstest-weights-2569-w9.ttf
components/gfx/tests/support/CSSTest/csstest-weights-258-w2.ttf
components/gfx/tests/support/CSSTest/csstest-weights-258-w5.ttf
components/gfx/tests/support/CSSTest/csstest-weights-258-w8.ttf
components/gfx/tests/support/CSSTest/csstest-weights-300.ttf
components/gfx/tests/support/CSSTest/csstest-weights-3589-w3.ttf
components/gfx/tests/support/CSSTest/csstest-weights-3589-w5.ttf
components/gfx/tests/support/CSSTest/csstest-weights-3589-w8.ttf
components/gfx/tests/support/CSSTest/csstest-weights-3589-w9.ttf
components/gfx/tests/support/CSSTest/csstest-weights-400.ttf
components/gfx/tests/support/CSSTest/csstest-weights-47-w4.ttf
components/gfx/tests/support/CSSTest/csstest-weights-47-w7.ttf
components/gfx/tests/support/CSSTest/csstest-weights-500.ttf
components/gfx/tests/support/CSSTest/csstest-weights-600.ttf
components/gfx/tests/support/CSSTest/csstest-weights-700.ttf
components/gfx/tests/support/CSSTest/csstest-weights-800.ttf
components/gfx/tests/support/CSSTest/csstest-weights-900.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w1.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w2.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w3.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w4.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w5.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w6.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w7.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w8.ttf
components/gfx/tests/support/CSSTest/csstest-weights-full-w9.ttf
components/gfx/tests/support/CSSTest/csstest-weights.ttf
components/layout/context.rs
components/layout/inline.rs
components/layout/text.rs