Builder linux-rel-css Build #5916

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 4 secs )
   1. - no logs -
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. shell__1 './mach clean-nightlies ...' ( 9 secs )
   1. stdio
6. compile ran build --release --with-debug-assertions warnings ( 19 mins, 33 secs )
   1. warnings (42)
7. test ran test-css --release --processes 16 --always-succeed ( 12 mins, 13 secs )
   1. css-errorsummary.log
8. shell__2 './mach filter-intermittents ...' ( 0 secs )
   1. stdio
   2. filtered-css-errorsummary.log
   3. intermittents.log
9. compile__1 ran build-cef --release --with-debug-assertions ( 38 secs )
   1. stdio
10. compile__2 ran build-geckolib --release ( 7 mins, 22 secs )
    1. - no logs -
11. test__1 ran test-stylo --release ( 51 secs )
    1. - no logs -
12. shell__3 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
13. shell__4 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
    1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #60647

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Sat 09 Sep 2017 09:50:24
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	auto
   Revision	40c8a6389afdad8fdffdf4a5616627f9a51b1822

   Comments

   Auto merge of #17083 - danielj41:javascript-url-global-3, r=jdm
   
   "javascript:" urls: execute in correct global scope
   
   <!-- Please describe your changes on the following line: -->
   
   #### Summary
   
   This pull request makes `javascript:` urls execute in the correct global scope.
   
   #### Example
   
   ```html
   <script> var x = 4; </script>
   
   <!-- this branch: logs "4" -->
   <!-- master: undefined variable error -->
   <a href="javascript:console.log(x)">link</a>
   ```
   
   #### Questions
   
   I'm new to servo and rust, so I'm unsure about these changes. In particular:
     * What's the appropriate place to evaluate the js?
       * I moved it to `handle_navigate`, but I'm not sure if this will catch all occurrences of `javascript:` urls. I also don't know if this will execute in the correct thread and the correct window.
     * What should I do with the result of the js evaluation?
       * I just ignored it. The previous behavior displayed it as the content of a new page load.
   
   ---
   <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
   - [x] `./mach build -d` does not report any errors
   - [x] `./mach test-tidy` does not report any errors
   - [x] These changes fix #15147, #16718
   
   <!-- Either: -->
   - [x] There are tests for these changes
   
   <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
   
   <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17083)
   <!-- Reviewable:end -->

   Changed files

   • components/constellation/constellation.rs
   • components/script/dom/htmliframeelement.rs
   • components/script/script_thread.rs
   • components/script_traits/lib.rs
   • components/script_traits/script_msg.rs
   • tests/wpt/metadata/MANIFEST.json
   • tests/wpt/metadata/XMLHttpRequest/open-url-javascript-window-2.htm.ini
   • tests/wpt/metadata/XMLHttpRequest/open-url-javascript-window.htm.ini
   • tests/wpt/metadata/dom/nodes/Document-contentType/contentType/contenttype_javascripturi.html.ini
   • tests/wpt/metadata/html/browsers/browsing-the-web/navigating-across-documents/013.html.ini
   • tests/wpt/metadata/html/browsers/browsing-the-web/navigating-across-documents/014.html.ini
   • tests/wpt/metadata/html/browsers/browsing-the-web/navigating-across-documents/015.html.ini
   • tests/wpt/metadata/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-query-fragment-components.html.ini
   • tests/wpt/metadata/html/dom/documents/dom-tree-accessors/Document.currentScript.html.ini
   • tests/wpt/metadata/old-tests/submission/Opera/script_scheduling/028.html.ini
   • tests/wpt/metadata/old-tests/submission/Opera/script_scheduling/029.html.ini
   • tests/wpt/web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-global-scope.html