Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #3517

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchauto
Revision2d732d829b3fc93938898118ee55ef985ebfc657
Got Revision2d732d829b3fc93938898118ee55ef985ebfc657
Changes1 change

BuildSlave:

servo-linux3

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 2 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 0 secs )
    1. stdio
  6. compile ran build --release --with-debug-assertions warnings ( 10 mins, 13 secs )
    1. stdio
    2. warnings (1)
  7. test ran test-css --release --processes 16 --always-succeed ( 10 mins, 4 secs )
    1. css-errorsummary.log
  8. shell__2 './mach filter-intermittents ...' ( 0 secs )
    1. stdio
    2. filtered-css-errorsummary.log
    3. intermittents.log
  9. compile__1 ran build-cef --release --with-debug-assertions ( 36 secs )
    1. stdio
  10. compile__2 ran build-geckolib --release ( 8 secs )
    1. stdio
  11. test__1 ran test-stylo --release ( 2 secs )
    1. - no logs -
  12. shell__3 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  13. shell__4 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch auto Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 3517 Build
codebase Build
got_revision 2d732d829b3fc93938898118ee55ef985ebfc657 Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 2d732d829b3fc93938898118ee55ef985ebfc657 Build
scheduler servo-auto Scheduler
slavename servo-linux3 BuildSlave
warnings-count 1 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartThu Apr 20 06:06:51 2017
EndThu Apr 20 06:28:00 2017
Elapsed21 mins, 8 secs

All Changes:

:

  1. Change #43887

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Thu 20 Apr 2017 06:06:51
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch auto
    Revision 2d732d829b3fc93938898118ee55ef985ebfc657

    Comments

    Auto merge of #16472 - cu1t:#14095-fix-xml-doc-namespaces, r=nox
    
    Fix namespaces of elements created in XML documents
    
    Correctly implement following step of [Dom Document Spec](https://dom.spec.whatwg.org/#dom-document-createelement):
    > Let namespace be the HTML namespace, if the context object is an HTML document or context object’s content type is "application/xhtml+xml", and null otherwise.
    
    Note, this will make following test in `tests/wpt/web-platform-tests/dom/nodes/Document-constructor.html` to fail, so related .ini file added to mark it as such:
    ```
    test(function() {
      var doc = new Document();
      var a = doc.createElement("a");
      // In UTF-8: 0xC3 0xA4
      a.href = "http://example.org/?\u00E4";
      assert_equals(a.href, "http://example.org/?%C3%A4");
    }, "new Document(): URL parsing")
    ```
    I'm not very familiar with specs, but from quick look at it, I'm doubtfull that it is valid in the first place. This is an "application/xml" document, so I don't see why it should encode a.href. Firefox also fails that.
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
    - [X] `./mach build -d` does not report any errors
    - [X] `./mach test-tidy` does not report any errors
    - [X] These changes fix #14095 (github issue number if applicable).
    
    <!-- Either: -->
    - [ ] There are tests for these changes OR
    - [X] These changes do not require tests because because there are already tests which were being ignored
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16472)
    <!-- Reviewable:end -->

    Changed files

    • components/script/dom/document.rs
    • tests/wpt/metadata/dom/nodes/Document-constructor.html.ini
    • tests/wpt/metadata/dom/nodes/Node-properties.html.ini
    • tests/wpt/mozilla/meta/MANIFEST.json
    • tests/wpt/mozilla/tests/mozilla/document_head.html