Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #3219

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchauto
Revision8d8fea0b4bf323be42eff3ad5624ce33892fb6df
Got Revision8d8fea0b4bf323be42eff3ad5624ce33892fb6df
Changes1 change

BuildSlave:

servo-linux1

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 3 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. compile ran build --release --with-debug-assertions ( 10 mins, 13 secs )
    1. stdio
  6. test ran test-css --release --processes 8 --always-succeed ( 15 mins, 25 secs )
    1. css-errorsummary.log
  7. shell__1 './mach filter-intermittents ...' ( 0 secs )
    1. stdio
    2. filtered-css-errorsummary.log
    3. intermittents.log
  8. compile__1 ran build-cef --release --with-debug-assertions ( 35 secs )
    1. stdio
  9. compile__2 ran build-geckolib --release ( 1 secs )
    1. stdio
  10. test__1 ran test-stylo --release ( 2 secs )
    1. - no logs -
  11. shell__2 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  12. shell__3 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch auto Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 3219 Build
codebase Build
got_revision 8d8fea0b4bf323be42eff3ad5624ce33892fb6df Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 8d8fea0b4bf323be42eff3ad5624ce33892fb6df Build
scheduler servo-auto Scheduler
slavename servo-linux1 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartTue Apr 4 23:17:44 2017
EndTue Apr 4 23:44:06 2017
Elapsed26 mins, 21 secs

All Changes:

:

  1. Change #41590

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Tue 04 Apr 2017 23:17:43
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch auto
    Revision 8d8fea0b4bf323be42eff3ad5624ce33892fb6df

    Comments

    Auto merge of #16234 - mckaymatt:as_void_ptr_helper_method_15252, r=jdm
    
    Add as_void_ptr helper method to &T
    
    <!-- Please describe your changes on the following line: -->
    r? @jdm
    issue https://github.com/servo/servo/issues/15252
    The primary goal of this PR is to add add a generic trait method that returns a void ptr.
    
    In addition to that change, I made the casting explicit in `components/script/dom/bindings/callback.rs`  and `components/script/dom/promise.rs`. I did not use the new trait method because `AddRawValueRoot` is not looking for a `c_void`. It's looking for `std::os::raw::c_char`.
    ```rust
    pub fn AddRawValueRoot(cx: *mut JSContext, vp: *mut Value,
                                              name: *const ::std::os::raw::c_char) -> bool;
    ```
    So I replace the `as *const _ ` with a more specific cast.
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
    - [x] `./mach build -d` does not report any errors
    - [x] `./mach test-tidy` does not report any errors
    - [x] These changes fix #15252
    
    <!-- Either: -->
    - [ ] There are tests for these changes OR
    - [x] These changes do not require tests because
     This seems like code cleanup. It shouldn't change behaviour.
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16234)
    <!-- Reviewable:end -->

    Changed files

    • components/script/dom/bindings/callback.rs
    • components/script/dom/bindings/codegen/CodegenRust.py
    • components/script/dom/bindings/utils.rs
    • components/script/dom/browsingcontext.rs
    • components/script/dom/promise.rs