Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #2772

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchauto
Revision8f7c69e15f0b9beddad2ba67e3419f88aca0d579
Got Revision8f7c69e15f0b9beddad2ba67e3419f88aca0d579
Changes1 change

BuildSlave:

servo-linux2

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 4 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. compile ran build --release --with-debug-assertions ( 10 mins, 16 secs )
    1. stdio
  6. test ran test-css --release --processes 16 --always-succeed ( 13 mins, 24 secs )
    1. css-errorsummary.log
  7. shell__1 './mach filter-intermittents ...' ( 0 secs )
    1. stdio
    2. filtered-css-errorsummary.log
    3. intermittents.log
  8. compile__1 ran build-cef --release --with-debug-assertions ( 37 secs )
    1. stdio
  9. compile__2 ran build-geckolib --release ( 1 secs )
    1. stdio
  10. test__1 ran test-stylo --release ( 2 secs )
    1. - no logs -
  11. shell__2 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  12. shell__3 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch auto Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 2772 Build
codebase Build
got_revision 8f7c69e15f0b9beddad2ba67e3419f88aca0d579 Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 8f7c69e15f0b9beddad2ba67e3419f88aca0d579 Build
scheduler servo-auto Scheduler
slavename servo-linux2 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartFri Mar 10 01:21:30 2017
EndFri Mar 10 01:45:56 2017
Elapsed24 mins, 26 secs

All Changes:

:

  1. Change #38991

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Fri 10 Mar 2017 01:21:28
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch auto
    Revision 8f7c69e15f0b9beddad2ba67e3419f88aca0d579

    Comments

    Auto merge of #15783 - ferjm:issue15756-parse-hosts, r=avadacatavra
    
    Replace manual host parsing code with parse-host crate
    
    This patch is replacing the code to parse the hosts file with the [parse-hosts](https://crates.io/crates/parse-hosts) crate. This crate has a [CC0 1.0 Universal License](https://creativecommons.org/publicdomain/zero/1.0/deed.en).
    
    I could have used [HostsFile::load()](https://clarcharr.github.io/parse-hosts/parse_hosts/struct.HostsFile.html#method.load) directly, but this method loads `/etc/hosts` by default and does not allow to override the default path (for example with [env::var("HOST_FILE")](https://dxr.mozilla.org/servo/source/components/net_traits/hosts.rs#19)), so I kept the existing code to open and read the content of `env::var("HOST_FILE")` and also kept the [parse_hostsfile](https://dxr.mozilla.org/servo/source/components/net_traits/hosts.rs#42) method (used by the unit tests), but I modified it to use [HostsFile::read_buffered](https://clarcharr.github.io/parse-hosts/parse_hosts/struct.HostsFile.html#method.read_buffered), which is doing the actual hosts parsing for a given string buffer.
    
    - [X] `./mach build -d` does not report any errors
    - [X] `./mach test-tidy` does not report any errors
    - [X] These changes fix #15756 .
    - [X] There are tests for these changes (tests/unit/net/resource_thread.rs and tests/unit/net/http_loader.rs)
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15783)
    <!-- Reviewable:end -->

    Changed files

    • Cargo.lock
    • components/net_traits/Cargo.toml
    • components/net_traits/hosts.rs
    • components/net_traits/lib.rs