Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #2252

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchtry
Revisionc5b9a4973b567306e02ddeced1ef77fb312a4549
Got Revisionc5b9a4973b567306e02ddeced1ef77fb312a4549
Changes1 change

BuildSlave:

servo-linux2

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

  1. git update ( 5 secs )
    1. - no logs -
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. compile ran build --release --with-debug-assertions ( 23 mins, 8 secs )
    1. - no logs -
  6. test ran test-css --release --processes 16 --always-succeed ( 12 mins, 20 secs )
    1. css-errorsummary.log
  7. shell__1 './mach filter-intermittents ...' ( 0 secs )
    1. stdio
    2. filtered-css-errorsummary.log
    3. intermittents.log
  8. compile__1 ran build-cef --release --with-debug-assertions ( 50 secs )
    1. stdio
  9. compile__2 ran build-geckolib --release warnings ( 3 mins, 49 secs )
    1. warnings (6)
  10. test__1 ran test-stylo --release warnings ( 2 mins, 29 secs )
    1. warnings (4)
  11. shell__2 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  12. shell__3 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch try Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 2252 Build
codebase Build
got_revision c5b9a4973b567306e02ddeced1ef77fb312a4549 Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision c5b9a4973b567306e02ddeced1ef77fb312a4549 Build
scheduler servo-auto Scheduler
slavename servo-linux2 BuildSlave
warnings-count 10 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartTue Feb 7 15:04:09 2017
EndTue Feb 7 15:46:53 2017
Elapsed42 mins, 43 secs

All Changes:

:

  1. Change #35643

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Tue 07 Feb 2017 15:04:09
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch try
    Revision c5b9a4973b567306e02ddeced1ef77fb312a4549

    Comments

    Auto merge of #15423 - mozfreddyb:fix-15386, r=<try>
    
    crop_area_bytes_length multiplies width and height (fixes #15386)
    
    <!-- Please describe your changes on the following line: -->
    `crop_image()` in component/canvas/canvas_paint_thread.rs calculated the crop_area_bytes_length variable by multiplying `height*height*4`
    
    It should multiply `height*width*4`, like so
    
    ```diff
    -    let crop_area_bytes_length = crop_rect.size.height * crop_rect.size.height * 4;
    +    let crop_area_bytes_length = crop_rect.size.height * crop_rect.size.width * 4;
    ```
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
    - [X] `./mach build -d` does not report any errors
    - [X] `./mach test-tidy` does not report any errors
    - [X] These changes fix #15386
    
    <!-- Either: -->
    - [ ] There are tests for these changes OR
    - [ ] These changes do not require tests because _____
    
    ^--- Not entirely sure here ;)
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15423)
    <!-- Reviewable:end -->

    Changed files

    • components/canvas/canvas_paint_thread.rs