Builder linux-rel-css Build #1686

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'servo-auto' triggered this build

Steps and Logfiles:

1. git update ( 4 secs )
   1. - no logs -
2. generic generic ( 0 secs )
   1. - no logs -
3. generic_1 generic_1 ( 0 secs )
   1. - no logs -
4. shell 'pkill -x ...' ( 0 secs )
   1. stdio
5. compile ran build --release --with-debug-assertions ( 23 mins, 3 secs )
   1. - no logs -
6. test ran test-css --release --processes 16 --always-succeed ( 14 mins, 3 secs )
   1. css-errorsummary.log
7. shell__1 './mach filter-intermittents ...' ( 0 secs )
   1. stdio
   2. filtered-css-errorsummary.log
   3. intermittents.log
8. compile__1 ran build-cef --release --with-debug-assertions ( 48 secs )
   1. stdio
9. compile__2 ran build-geckolib --release warnings ( 4 mins, 10 secs )
   1. warnings (6)
10. test__1 ran test-stylo --release warnings ( 2 mins, 10 secs )
    1. warnings (4)
11. shell__2 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
12. shell__3 'bash ./etc/ci/manifest_changed.sh' ( 0 secs )
    1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. bors-servo

   lbergstrom+borsohnoyoudont@mozilla.com

Timing:

All Changes:

:

1. Change #31819

   Category	None
   Changed by	bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
   Changed at	Wed 04 Jan 2017 18:54:12
   Repository	https://github.com/servo/servo
   Project	servo/servo
   Branch	auto
   Revision	6f9ff7b8bf66cbeb7d539c6728db05f05aa8f85c

   Comments

   Auto merge of #14738 - Wafflespeanut:keypress, r=jdm
   
   Properly dispatch keypress event
   
   <!-- Please describe your changes on the following line: -->
   
   This was an attempt to fix #14659. It turned out that the problem wasn't what I thought it was. So, I didn't fix that. On the brighter side, this fixes two related issues.
   
   - Previously, we were unable to launch `keypress` events from `input` and `textarea` elements, because [we'd been cancelling](https://github.com/servo/servo/blob/1327ebd52f53f5f6637a12fab6cf0cad0aa0be6f/components/script/dom/htmlinputelement.rs#L1120-L1124) the key events, so that they don't trigger window navigation - #8400). I've introduced an enum to represent an additional state to an event's cancellation.
   - [According to the spec](https://w3c.github.io/uievents/#keypress-event-order), `keypress` (if available) should be dispatched immediately after `keydown`, and it should be followed by `input`. Canceling `keypress` should also cancel `input`. But, we'd been dispatching `input` before `keypress`. We now dispatch `input` once the `keypress` event is on the respective elements.
   
   ---
   <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
   - [x] `./mach build -d` does not report any errors
   - [x] `./mach test-tidy` does not report any errors
   
   <!-- Either: -->
   - [x] These changes do not require tests because it's a refactor?
   
   <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
   
   r? @jdm or anyone interested
   
   <!-- Reviewable:start -->
   ---
   This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14738)
   <!-- Reviewable:end -->

   Changed files

   • components/atoms/static_atoms.txt
   • components/script/dom/document.rs
   • components/script/dom/event.rs
   • components/script/dom/htmlinputelement.rs
   • components/script/dom/htmltextareaelement.rs