Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #13482

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchtry-wpt
Revisionc1014def317e4837a6e6b1046a15d1a6d9162783
Got Revisionc1014def317e4837a6e6b1046a15d1a6d9162783
Changes1 change

BuildSlave:

servo-linux2

Reason:

The SingleBranchScheduler scheduler named 'wpt-push' triggered this build

Steps and Logfiles:

  1. git update ( 4 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 15 secs )
    1. stdio
  6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
    1. stdio
  7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio
  8. compile ran build --release --with-debug-assertions -p servo ( 13 mins, 12 secs )
    1. - no logs -
  9. test ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 2 --always-succeed ( 11 mins, 45 secs )
    1. - no logs -
  10. shell__4 './mach filter-intermittents ...' ( 3 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
  11. test__1 ran test-wpt --release --processes 24 --always-succeed tests/wpt/webgl/tests/conformance ( 2 mins, 19 secs )
    1. webgl-errorsummary.log
  12. shell__5 './mach filter-intermittents ...' ( 0 secs )
    1. stdio
    2. webgl-intermittents.log
    3. filtered-webgl-errorsummary.log
  13. shell__6 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  14. shell__7 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch try-wpt Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 13482 Build
codebase Build
got_revision c1014def317e4837a6e6b1046a15d1a6d9162783 Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision c1014def317e4837a6e6b1046a15d1a6d9162783 Build
scheduler wpt-push Scheduler
slavename servo-linux2 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartTue Sep 24 18:12:42 2019
EndTue Sep 24 18:40:25 2019
Elapsed27 mins, 42 secs

All Changes:

:

  1. Change #123711

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Tue 24 Sep 2019 18:12:42
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch try-wpt
    Revision c1014def317e4837a6e6b1046a15d1a6d9162783

    Comments

    Auto merge of #23873 - RestitutorOrbis:jn-add-tao, r=<try>
    
    Add PerformanceResourceTiming:TimingAllowCheck
    
    Added timing allow check to http_loader.rs in `fn http_network_fetch`.
    
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
    - [x] `./mach build -d` does not report any errors
    - [x] `./mach test-tidy` does not report any errors
    - [x] These changes fix #21270
    
    ### Things to Do
    - [x] Map header values from Timing-Allow-Origin to URL types using [Url::Parse](https://docs.rs/url/2.0.0/url/)
    - [x] Check equality of those header URL origin with the origin in question
    - [x] Just use url instead of `res.origin`
    - [x] Change `.set_attribute(ResourceAttribute::RedirectStart(0))` to `.set_attribute(ResourceAttribute::RedirectStart(RedirectStartValue::Zero))`
    - [x] Change `.set_attribute(ResourceAttribute::RedirectEnd(0))` to `.set_attribute(ResourceAttribute::RedirectEnd(RedirectEndValue::Zero))`
    - [x] Figure out how to set DomainLookupStart, RequestStart, and ResponseStart without directly passing value as part of enum
    - [x] Figure out how to handle lack of DomainLookupEnd (#21260) and SecureConnectionStart (#21268)
    - [x] add a flag to ResourceFetchTiming that indicates if the timing check passed, and only update timing attributes if that flag is false
    - [x] add function to mark timing test as failed and set all attributes to 0
    - [x] resolve compile error regarding move of header_strings variable
    - [x] resolve URL parse errors that appear during test execution
    - [x] ~~Fix /resource-timing/crossorigin-sandwich-no-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html)
    - [x] ~~Fix /resource-timing/crossorigin-sandwich-TAO.sub.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html)
    - [x] ~~Fix /resource-timing/resource-reload-TAO.sub.html~~ (Get TIMEOUT, fails on Firefox too?)
    - [x] ~~Fix /resource-timing/resource_TAO_cross_origin_redirect_chain.html~~ (Problem seems to lie in loading the iFrame, when the request is made, the URL attached to the PerformanceResourceTiming interface is the initial URL set on the iFrame instead of the URL that is ultimately loaded)
    - [x] ~~Fix resource-timing/resource_TAO_multi_wildcard.html~~ (Doesn't work because IMG element doesn't generate HTTP request with Origin field)
    - [x] Fix /resource-timing/resource_TAO_match_origin.htm
    - [x] Fix /resource-timing/resource_TAO_match_wildcard.htm
    - [x] Fix /resource-timing/resource_TAO_multi.htm
    - [x] Fix /resource-timing/resource_TAO_wildcard.htm
    - [x] Fix /resource-timing/resource_TAO_zero.htm
    - [x] Fix /resource-timing/resource_TAO_null.htm
    - [x] Fix /resource-timing/resource_TAO_origin.htm (tests for responseStart and domainLookupEnd fail because #21260 and #21271 haven't been resolved)
    - [x] Fix /resource-timing/resource_TAO_space.htm
    - [x] Fix /resource-timing/resource_TAO_origin_uppercase.htm
    - [x] ~~Fix /resource-timing/resource_timing_TAO_cross_origin_redirect.html~~ (Refer to resource_TAO_cross_origin_redirect_chain.html)
    - [x] ~~Fix /resource-timing/TAO-case-insensitive-null-opaque-origin.sub.html~~ (TIMEOUT, doesn't seem to parse iFrame SRC correctly? There doesn't seem to be any sign that it makes a request to TAOResponse.py)
    - [x] Fix /resource-timing/TAO-crossorigin-port.sub.html
    - [x] ~~Fix /resource-timing/TAO-null-opaque-origin.sub.html~~ (Refer to /resource-timing/TAO-crossorigin-port.sub.html)
    - [x] /navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html
    - [x] /navigation-timing/nav2_test_document_open.html
    - [x] /navigation-timing/nav2_test_frame_removed.html
    - [x] /performance-timeline/not-clonable.html
    - [x] /navigation-timing/nav2_test_redirect_xserver.html
    - [x] /resource-timing/resource_connection_reuse.https.html
    - [x] /resource-timing/resource_reparenting.html
    - [x] /resource-timing/resource_connection_reuse.html
    - [x] /resource-timing/resource_script_types.html
    - [x] /resource-timing/idlharness.any.html
    - [x] /resource-timing/clear_resource_timing_functionality.html
    - [x] /resource-timing/idlharness.any.worker.html
    - [x] /resource-timing/resource_cached.htm
    - [x] /resource-timing/resource_connection_reuse_mixed_content_redirect.html
    - [x] /resource-timing/resource_connection_reuse_mixed_content.html
    - [x] /resource-timing/resource_timing_buffer_full_when_shrink_buffer_size.html
    - [x] /navigation-timing/idlharness.window.html
    - [x] /navigation-timing/nav2_test_navigate_iframe.html
    - [x] /navigation-timing/nav2_test_navigate_within_document.html
    - [x] /resource-timing/resource_reuse.sub.html
    - [x] /navigation-timing/nav2_test_instance_accessible_from_the_start.html
    - [x] /resource-timing/resource_dedicated_worker.html
    - [x] /navigation-timing/unload-event-same-origin-check.html
    - [x] /navigation-timing/nav2_test_navigation_type_backforward.html
    
    <!-- Either: -->
    - [x] There are tests for these changes OR
    - [ ] These changes do not require tests because ___
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23873)
    <!-- Reviewable:end -->

    Changed files

    • components/net/fetch/methods.rs
    • components/net/http_loader.rs
    • components/net/resource_thread.rs
    • components/net/tests/fetch.rs
    • components/net/tests/main.rs
    • components/net_traits/lib.rs
    • components/net_traits/response.rs
    • components/script/dom/performanceresourcetiming.rs
    • components/script/dom/webidls/PerformanceResourceTiming.webidl
    • tests/wpt/metadata/navigation-timing/idlharness.window.js.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_document_open.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_frame_removed.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_instance_accessible_from_the_start.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_navigate_iframe.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_navigate_within_document.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_navigation_type_backforward.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html.ini
    • tests/wpt/metadata/navigation-timing/nav2_test_redirect_xserver.html.ini
    • tests/wpt/metadata/navigation-timing/unload-event-same-origin-check.html.ini
    • tests/wpt/metadata/performance-timeline/not-clonable.html.ini
    • tests/wpt/metadata/resource-timing/TAO-crossorigin-port.sub.html.ini
    • tests/wpt/metadata/resource-timing/clear_resource_timing_functionality.html.ini
    • tests/wpt/metadata/resource-timing/idlharness.any.js.ini
    • tests/wpt/metadata/resource-timing/resource_TAO_multi_wildcard.html.ini
    • tests/wpt/metadata/resource-timing/resource_TAO_null.htm.ini
    • tests/wpt/metadata/resource-timing/resource_TAO_origin_uppercase.htm.ini
    • tests/wpt/metadata/resource-timing/resource_TAO_space.htm.ini
    • tests/wpt/metadata/resource-timing/resource_TAO_zero.htm.ini
    • tests/wpt/metadata/resource-timing/resource_cached.htm.ini
    • tests/wpt/metadata/resource-timing/resource_connection_reuse.html.ini
    • tests/wpt/metadata/resource-timing/resource_connection_reuse.https.html.ini
    • tests/wpt/metadata/resource-timing/resource_connection_reuse_mixed_content.html.ini
    • tests/wpt/metadata/resource-timing/resource_connection_reuse_mixed_content_redirect.html.ini
    • tests/wpt/metadata/resource-timing/resource_dedicated_worker.html.ini
    • tests/wpt/metadata/resource-timing/resource_reparenting.html.ini
    • tests/wpt/metadata/resource-timing/resource_reuse.sub.html.ini
    • tests/wpt/metadata/resource-timing/resource_script_types.html.ini
    • tests/wpt/metadata/resource-timing/resource_timing_buffer_full_when_shrink_buffer_size.html.ini
    • tests/wpt/metadata/workers/worker-performance.worker.js.ini