Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #12670

Results:

Build successful

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchtry-wpt
Revision7be27701350bbabe428387e1e51e5234b1a7a77e
Got Revision7be27701350bbabe428387e1e51e5234b1a7a77e
Changes1 change

BuildSlave:

servo-linux6

Reason:

The SingleBranchScheduler scheduler named 'wpt-push' triggered this build

Steps and Logfiles:

  1. git update ( 4 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. stdio
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 14 secs )
    1. stdio
  6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
    1. stdio
  7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio
  8. compile ran build --release --with-debug-assertions -p servo ( 12 mins, 30 secs )
    1. - no logs -
  9. test ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 2 --always-succeed ( 12 mins, 59 secs )
    1. - no logs -
  10. shell__4 './mach filter-intermittents ...' ( 5 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
  11. shell__5 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  12. shell__6 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch try-wpt Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 12670 Build
codebase Build
got_revision 7be27701350bbabe428387e1e51e5234b1a7a77e Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 7be27701350bbabe428387e1e51e5234b1a7a77e Build
scheduler wpt-push Scheduler
slavename servo-linux6 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartMon Jul 1 11:06:25 2019
EndMon Jul 1 11:32:21 2019
Elapsed25 mins, 56 secs

All Changes:

:

  1. Change #118157

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Mon 01 Jul 2019 11:06:25
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch try-wpt
    Revision 7be27701350bbabe428387e1e51e5234b1a7a77e

    Comments

    Auto merge of #23670 - braddunbar:https-scheme, r=<try>
    
    Implement checks on Location setters
    
    So, this is my first pull to servo. I've tried to follow all the directions, but I may have missed or forgotten some of them. If so, please let me know - I'll be happy to fix things up!
    
    As described in #23522, this implements various checks on the Location setters. In particular, for the following components.
    
    * protocol
    * host
    * hostname
    * port
    * pathname
    
    I'd also like to add code for throwing a `SyntaxError` when appropriate, but I may do that separately.
    
    I've removed the expectations for the protocol setter tests, but I haven't yet found any failing tests for the other components. Should I write tests for those? If so, should I add them here or is there an upstream that I should contribute to?
    
    Let me know what you think!
    
    ---
    - [x] `./mach build -d` does not report any errors
    - [x] `./mach test-tidy` does not report any errors
    - [x] These changes fix #23522
    - [ ] There are tests for these changes
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23670)
    <!-- Reviewable:end -->

    Changed files

    • components/script/dom/location.rs
    • components/url/lib.rs
    • tests/wpt/metadata/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html.ini
    • tests/wpt/metadata/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html.ini