Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder linux-rel-css Build #12212

Results:

Failed shell__4

SourceStamp:

Projectservo/servo
Repositoryhttps://github.com/servo/servo
Branchtry-wpt
Revision47d500eec681fd4fde9ff5c5faa7d741795ad110
Got Revision47d500eec681fd4fde9ff5c5faa7d741795ad110
Changes1 change

BuildSlave:

servo-linux4

Reason:

The SingleBranchScheduler scheduler named 'wpt-push' triggered this build

Steps and Logfiles:

  1. git update ( 2 secs )
    1. stdio
  2. generic generic ( 0 secs )
    1. - no logs -
  3. generic_1 generic_1 ( 0 secs )
    1. - no logs -
  4. shell 'pkill -x ...' ( 0 secs )
    1. stdio
  5. shell__1 './mach clean-nightlies ...' ( 14 secs )
    1. stdio
  6. shell__2 './mach clean-cargo-cache ...' ( 0 secs )
    1. stdio
  7. shell__3 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio
  8. compile ran build --release --with-debug-assertions -p servo ( 10 mins, 38 secs )
    1. - no logs -
  9. test ran test-wpt --release --processes 24 --total-chunks 2 --this-chunk 2 --always-succeed ( 12 mins, 5 secs )
    1. - no logs -
  10. shell__4 './mach filter-intermittents ...' failed ( 5 secs )
    1. stdio
    2. filtered-wpt-errorsummary.log
  11. shell__5 'bash ./etc/ci/lockfile_changed.sh' ( 0 secs )
    1. stdio
  12. shell__6 './etc/ci/clean_build_artifacts.sh' ( 0 secs )
    1. stdio

Build Properties:

NameValueSource
branch try-wpt Build
builddir /home/servo/buildbot/slave/linux-rel-css slave
buildername linux-rel-css Builder
buildnumber 12212 Build
codebase Build
got_revision 47d500eec681fd4fde9ff5c5faa7d741795ad110 Git
project servo/servo Build
repository https://github.com/servo/servo Build
revision 47d500eec681fd4fde9ff5c5faa7d741795ad110 Build
scheduler wpt-push Scheduler
slavename servo-linux4 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/servo/buildbot/slave/linux-rel-css slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. bors-servo

Timing:

StartMon May 13 05:21:25 2019
EndMon May 13 05:44:33 2019
Elapsed23 mins, 8 secs

All Changes:

:

  1. Change #113713

    Category None
    Changed by bors-servo <lbergstrom+borsohnoyoudont@mozilla.com>
    Changed at Mon 13 May 2019 05:21:25
    Repository https://github.com/servo/servo
    Project servo/servo
    Branch try-wpt
    Revision 47d500eec681fd4fde9ff5c5faa7d741795ad110

    Comments

    Auto merge of #23368 - gterzian:clean_up_navigation, r=<try>
    
    [WIP] Clean-up navigation
    
    <!-- Please describe your changes on the following line: -->
    
    1. Navigation as a result of following a hyperlink should be done in a task: https://html.spec.whatwg.org/multipage/links.html#following-hyperlinks:dom-manipulation-task-source
    2. The javascript url navigation should also be done in a task: https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigating-across-documents:dom-manipulation-task-source
    3. In `window.load_url`, it seems there is no need to send a message to the script-thread(the entirety of `load_url` should instead be done in a task when appropriate), so we can just do that last part "sync" by calling a method on the script, which will send a message to the constellation(for the parallel navigation steps), or queue task(for the JS navigation), as appropriate.
    4. Separate the "normal" navigation flow from the handling of "navigate an iframe" message from constellation, since doing everything in one method as was previously done with `handle_navigate`, is confusing.
    
    ---
    <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
    - [ ] `./mach build -d` does not report any errors
    - [ ] `./mach test-tidy` does not report any errors
    - [ ] These changes fix #___ (GitHub issue number if applicable)
    
    <!-- Either: -->
    - [ ] There are tests for these changes OR
    - [ ] These changes do not require tests because ___
    
    <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
    
    <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23368)
    <!-- Reviewable:end -->

    Changed files

    • components/constellation/constellation.rs
    • components/script/dom/htmlanchorelement.rs
    • components/script/dom/htmlformelement.rs
    • components/script/dom/location.rs
    • components/script/dom/window.rs
    • components/script/dom/windowproxy.rs
    • components/script/script_thread.rs
    • components/script_traits/lib.rs